Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4187 split up commands #4191

Closed
wants to merge 1 commit into from
Closed

4187 split up commands #4191

wants to merge 1 commit into from

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Part of #4187
Split up commands into a list so we could use them one by one

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@VakarisZ VakarisZ marked this pull request as ready for review June 11, 2024 09:36
ilija-lazoroski
ilija-lazoroski reviewed Jun 11, 2024
View reviewed changes
monkey/infection_monkey/command_builders/linux_agent_command_builder.py
f"wget -qO {destination_path} {download_url}; "
f"{self._set_permissions_command(destination_path)}; "
)
) -> List[str]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use just list

@VakarisZ
Copy link
Contributor Author

Closed in favor of #4192

@VakarisZ VakarisZ closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilija-lazoroski ilija-lazoroski ilija-lazoroski left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VakarisZ @ilija-lazoroski