Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block-builder bugfix: OOO native histogram is a non-terminal error #9648

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

seizethedave
Copy link
Contributor

@seizethedave seizethedave commented Oct 16, 2024

What this PR does

This applies the same logic from #9567 to block-builder. This currently has the effect of stopping block-builder ingestion when an OOO native histogram is encountered.

(We're going to follow back up on this to consolidate the list of errors that constitute terminal vs non-terminal errors between block-builder and ingester.)

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@seizethedave seizethedave marked this pull request as ready for review October 16, 2024 17:38
@seizethedave seizethedave requested a review from a team as a code owner October 16, 2024 17:38
@seizethedave seizethedave requested a review from codesome October 16, 2024 17:45
@seizethedave seizethedave merged commit b0fcf34 into main Oct 16, 2024
29 checks passed
@seizethedave seizethedave deleted the davidgrant/bb-obs branch October 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants