Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest storage: don't return an error when records are successfully ingested #9501

Merged
merged 1 commit into from
Oct 2, 2024
Merged

ingest storage: don't return an error when records are successfully ingested #9501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/storage/ingest/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,8 @@ func (r *PartitionReader) consumeFetches(ctx context.Context, fetches kgo.Fetche
err := consumer.Consume(consumeCtx, records)
if err == nil {
level.Debug(logger).Log("msg", "closing consumer after successful consumption")
break
// The context might have been cancelled in the meantime, so we return here instead of breaking the loop and returning the context error
return nil
}
level.Error(logger).Log(
"msg", "encountered error while ingesting data from Kafka; should retry",
Expand Down
Loading