Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest storage: don't return an error when records are successfully ingested #9501

Merged

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

This fixes a flaky TestPartitionReader_Commit because we'd shut down the reader right after receiving the records. That would return an error as if ingesting caused an error. The bug was introduced in #9454 where we did the opposite change. The opposite change isn't functionally necessary.

Which issue(s) this PR fixes or relates to

Related to #8697

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…ngested

This fixes a flaky TestPartitionReader_Commit because we'd shut down the reader. The bug was introduced in XXX

Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner October 2, 2024 15:59
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitarvdimitrov dimitarvdimitrov merged commit 28a2d41 into main Oct 2, 2024
29 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/ingest/fix-flaky-TestPartitionReader_Commit branch October 2, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants