mimir-build-image: update to Debian Bookworm #6980
Conversation
Current image has an old sed 4.7 version installed, which fails to work properly under certain conditions on OSX, failing as: /bin/sed: couldn't open temporary file ...: Permission denied This seems to be fixed in 4.8 [1], which is available in Bookworm, and I could workaround by bringing the backports, but it's just easier to update the build image. [1]: https://forums.docker.com/t/sed-couldnt-open-temporary-file-xyz-permission-denied-when-using-virtiofs/125473 Signed-off-by: Oleg Zaytsev <[email protected]>
|
Push mimir-build-image / build_and_push is skipped... don't see why |
ying-jeanne
force-pushed
the
mimir-build-image-bookworm
branch
from
28e5111 to
56c6ed3
Compare
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
|
pushed a commit to solve the build issue |
|
Thank you, @ying-jeanne ! |
colega
requested review from
wilfriedroset,
vaxvms and
bubu11e
as code owners
|
What's wrong now? Why the build doesn't run? |
|
@colega I think it's due to a shortcoming in GitHub Actions. It doesn't re-trigger when the workflow pushes its image updating commit. I work around it by pushing a commit manually (e.g. by rebasing). |
Signed-off-by: Oleg Zaytsev <[email protected]>
|
Oh I see, I guess github actions commits don't trigger github actions to avoid infinite loops. I've pushed an empty commit. Thank you @aknuds1 |
|
Not building new version of mimir-build-image. This PR modifies |
Signed-off-by: Oleg Zaytsev <[email protected]>
|
Not building new version of mimir-build-image. This PR modifies |
Seems that asome String() methods have changed Signed-off-by: Oleg Zaytsev <[email protected]>
|
Not building new version of mimir-build-image. This PR modifies |
Signed-off-by: Oleg Zaytsev <[email protected]>
|
Not building new version of mimir-build-image. This PR modifies |
|
Merged main with an updated build image, I guess this should build another one now? |
|
Building new version of mimir-build-image. After image is built and pushed to Docker Hub, a new commit will automatically be added to this PR with new image version |
Signed-off-by: Oleg Zaytsev <[email protected]>
|
Not building new version of mimir-build-image. This PR modifies |
What this PR does
Current image has an old sed 4.7 version installed, which fails to work properly under certain conditions on OSX, failing as:
This seems to be fixed in 4.8 1, which is available in Bookworm, and I could workaround by bringing the backports, but it's just easier to update the build image.
Which issue(s) this PR fixes or relates to
Not reported I think.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.