Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copies some snippets that were in v3 only to gms #1715

Merged
merged 12 commits into from
Jul 24, 2024

Conversation

dkhawk
Copy link
Contributor

@dkhawk dkhawk commented Jul 23, 2024

chore: the java compatibility version

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x ] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [x ] Ensure the tests and linter pass
  • [x ] Code coverage does not decrease (if any source code was changed)
  • [x ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

chore: the java compatibility version
Copy link

snippet-bot bot commented Jul 23, 2024

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@dkhawk dkhawk requested a review from kikoso July 23, 2024 15:54
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We increased Java through the repo to 21.

@dkhawk dkhawk merged commit abcc8b5 into main Jul 24, 2024
10 checks passed
@dkhawk dkhawk deleted the feat/copy_snippets_to_gms branch July 24, 2024 16:56
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kikoso added a commit that referenced this pull request Aug 14, 2024
* feat: copies some snippets that were in v3 only to gms
chore: the java compatibility version

* fix: updates copyright dates and adds missing copyright

* fix: copyright header for strings.xml

* fix: set Java Version back to 17

* fix: set Java Version back to 17

* fix: set Java Version back to 17

* fix: set Java Version back to 17

* fix: set Java Version back to 17

* feat: creates AdvancedMarkersCollisionActivity to demonstrate marker collision behavior

* chore: not adding jar files in libs directory

* feat: set Java 21 everywhere

---------

Co-authored-by: Enrique López Mañas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants