Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure region tags exist in /gms samples #1713

Closed
wangela opened this issue Jul 22, 2024 · 2 comments
Closed

Make sure region tags exist in /gms samples #1713

wangela opened this issue Jul 22, 2024 · 2 comments
Assignees
@dkhawk
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wangela
Copy link
Contributor

wangela commented Jul 22, 2024

Some features which were initially introduced in the v3 beta are now available in the Play Services version of the SDK. The samples and region tags that indicate the source for code snippets on https://developers.google.com/maps/documentation/android-sdk/shapes need to exist in the /gms Java and Kotlin directories so that the documentation can get out of dependency on the /v3 samples folder.

This search will show all region tags that exist in the /v3 folder.
@wangela wangela added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. triage me I really want to be triaged. labels Jul 22, 2024
@wangela wangela added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jul 22, 2024
@wangela
Copy link
Contributor Author

wangela commented Jul 22, 2024

Copy PolylineCustomizationActivity.java and .kt over for:

  • maps_android_polyline_multicolored
  • maps_android_polyline_gradient
  • maps_android_polyline_stamped

Copy POIBehaviorActivity.java and .kt over and replace with AdvancedMarkerOptions based on this code snippet for:

  • maps_android_marker_collision

Copy CloudBasedMapStylingActivity.java and .kt over for:

  • maps_android_cloud_based_map_styling

@wangela
Copy link
Contributor Author

wangela commented Jul 29, 2024

Fixed in PR #1715 and #1716

@wangela wangela closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkhawk dkhawk

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkhawk @wangela