Unlock redsync locks using context.Background() #1578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using the same context that was passed in from the original call, there's a risk that the context has been canceled. This would cause the Unlock operation to fail and leave the lock in a locked state.
glindstedt
requested review from
aLekSer,
HazWard,
calebatwd,
sawagh,
amg84,
scosgrave,
markmandel and
joeholley
as code owners
|
Note: Backfills is a community-contributed feature, so we just merge PRs related to it into the next version provided tests pass and there's no obvious issues with the code. This will be in 1.8. Thanks for the contribution! |
joeholley
approved these changes
Jun 19, 2023
|
Manually merged into release-1.8 branch commit 74d84a2 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Context: #1576
We observed an issue where
CleanupBackfillswould leave backfill mutex locks in a locked state if the context was canceled, which prevented us from doing anything with the backfill until thebackfillLockTimeout. Even if the backfill had expired we had to wait for the timeout to find out about it.This PR ensures that the deferred
Unlockis performed using a background context, so if the original context was canceled we will still try to unlock the mutex.Which issue(s) this PR fixes:
Closes #1576
Special notes for your reviewer: