Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.8-rc1 #1587

Merged
merged 83 commits into from
Aug 30, 2023
Merged

Release 1.8-rc1 #1587

merged 83 commits into from
Aug 30, 2023

Conversation

joeholley
Copy link
Collaborator

@joeholley joeholley commented Aug 17, 2023 •
edited
Loading

Release Notes

Feature Highlights

Breaking Changes

  • Helm chart no longer supports installing Jaeger. The golang library this support was dependant on has been deprecated and moving to the latest version of other dependancies broke it. Any future tracing support will need to implement the OpenTelemetry standard (not included in this release)

Security Fixes

Enhancements

  • Bump golang to 1.21
  • Bump protoc version to 24.0
  • Bump gRPC Gateway to 2.16.2
  • Bump Kubectl version to 1.27.3
  • Bump Helm version to 3.12.3
  • Move CI/CD process to kaniko build cache to speed it up a bit

Usage Requirements
Tested against Kubernetes Version 1.24 and 1.25
Helm chart tested using Helm Version 3.12.3
Modifying Open Match core requires Golang Version >= v1.21

Will likely still need some changes to true up the examples, but I won't get around to testing them this week.

mridulji and others added 30 commits February 11, 2023 14:10
@mridulji
Release changes for v1.7.0-rc.1 (googleforgames#1534)
a818dc6 
* Update k8s.io packages (googleforgames#1531)

* update supported version of k8s.io/client-go

* update tutorial deps

* add context

* release changes for v1.7.0-rc.1
@mridulji
tutorial target version to v1.7.0-rc.1 (googleforgames#1535)
212751d
@mridulji
Release changes for v1.7.0 (googleforgames#1538)
86d4f4e 
* release changes for v1.7.0

* tutorial changes for v1.7.0
@joeholley
debug
772f72c
@joeholley
Debian Bookworm
0090471
@joeholley
Split sync-deps target into sync & clean targets; remove GO111MODULE …
a6d9f6d 
…var as it's no longer needed post Golang 1.16
@joeholley
splitting sync-deps step into clean & sync steps
64ef936
@joeholley
splitting sync-deps step into clean & sync steps pt 2
5f5fdf0
@joeholley
splitting sync-deps step into clean & sync steps pt 2
cfdff6f
@joeholley
Re-enable sync deps
8a3c474
@joeholley
Re-enable sync deps take 2
0a73b37
@joeholley
protobuf only target
0ef8e28
@joeholley
Add golang-protos make target step
41dda74
@joeholley
Add golang-protos make target step
3401e89
@joeholley
re-add
56f43cf
@joeholley
typo
351b456
@joeholley
re-enable terraform validate step
f2da171
@joeholley
re-enable terraform validate step take 2
e525739
@joeholley
re-enable build asset step
6b9805b
@joeholley
re-enable build binaries step
1f00381
@joeholley
re-enable golang tests step
60f87de
@joeholley
temp cgo testing
b246621
@joeholley
re-adding cgo to racew testing
e696197
@joeholley
Add gcc for CGO compliation
7803b81
@joeholley
Add gcc for CGO compliation
461d7df
@joeholley
Revert "Add gcc for CGO compliation"
4436e7c 
This reverts commit 461d7df.
@joeholley
Add gcc for CGO compliation
f097d71
@joeholley
turn goproxy back on to see if it gets past the module download
112175f
@joeholley
Remove references to old testing module location
2d6f1de
@joeholley
allow parallel testing
bd6254c
@joeholley joeholley requested a review from markmandel as a code owner August 17, 2023 03:56
@joeholley joeholley self-assigned this Aug 17, 2023
@joeholley joeholley added this to the v1.8.0 milestone Aug 17, 2023
This was linked to issues Aug 17, 2023
PodSecurityPolicy deprecated in k8s 1.25 #1449
Closed
Redis helm chart archive link 404 not found #1539
Open
PodSecurityPolicy In Grafana Dependency #1568
Open
Helm installation not working #1574
Open
Backfill mutex not unlocked when context is canceled in CleanupBackfills #1576
Open
@markmandel
Copy link
Member

Just checking if you want review yet or not, since conflicts + breaking build?

@ashutosji ashutosji mentioned this pull request Aug 21, 2023
Open
@joeholley
Copy link
Collaborator Author

Ready for review. I can't troubleshoot why the trigger check never passes (I don't have admin perms); AFAIK all it does is trigger the build, which /does/ complete and pass. No idea why the trigger never goes green.

markmandel
markmandel reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting!

testing/e2e/backfill_test.go Outdated Show resolved Hide resolved
testing/e2e/cluster_test.go Outdated Show resolved Hide resolved
@joeholley joeholley changed the base branch from main to release-1.8 August 22, 2023 05:35
@joeholley joeholley mentioned this pull request Aug 25, 2023
Merged
@Kaszanas
Copy link

If you need any assistance, I have experience in running the OpenMatch examples. I wasn't able to see any activity in logs after following the custom evaluator instructions. This is mostly related #1580

Additionally, some of the tutorial steps provide code for running multiple steps at the same time in the l command line or use newline indication which comes with it's own drawbacks dependent on the shell that it's ran in.

markmandel
markmandel approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

I had a quick look for the issue to be created for the e2e test you had to delete, and couldn't see it, but I may not be looking too hard as I run off to NEXT, so in case it's not there, please add it 😃

But otherwise, good to go!

cloudbuild.yaml
@@ -48,23 +45,31 @@

steps:
- id: 'Docker Image: open-match-build'
name: gcr.io/cloud-builders/docker
args: ['build', '-t', 'gcr.io/$PROJECT_ID/open-match-build', '-f', 'Dockerfile.ci', '.']
name: gcr.io/kaniko-project/executor:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice use of kaniko. I might steal this.

@joeholley joeholley merged commit 64f0ec7 into googleforgames:release-1.8 Aug 30, 2023
@joeholley
Copy link
Collaborator Author

I had a quick look for the issue to be created for the e2e test you had to delete, and couldn't see it, but I may not be looking too hard as I run off to NEXT, so in case it's not there, please add it 😃

(For tracking)
#1592
#1591

joeholley added a commit that referenced this pull request Oct 21, 2023
@joeholley
Merge Release 1.8 into Main (#1636)
dbda6c8 
* Release 1.8-rc1 (#1587)

* Release 1.8 (#1596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer aLekSer is a code owner

@HazWard HazWard Awaiting requested review from HazWard HazWard is a code owner

@calebatwd calebatwd Awaiting requested review from calebatwd calebatwd is a code owner

@sawagh sawagh Awaiting requested review from sawagh

@amg84 amg84 Awaiting requested review from amg84 amg84 is a code owner

@scosgrave scosgrave Awaiting requested review from scosgrave scosgrave is a code owner

Assignees

@joeholley joeholley

Labels
kind/release
Projects
None yet
Milestone
v1.8.0-rc.1
4 participants
@joeholley @markmandel @Kaszanas @mridulji