Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows containers examples and docs. #2047
Add Windows containers examples and docs. #2047
Changes from all commits
e2a49bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a quickstart -- I'm not sure if we want to mix in the Linux vs Windows container discussion at this point, since this section is more about getting started quickly. WDYT @roberthbailey ?
I would argue it likely makes more sense to have a separate "Windows game server" guide somewhere in the docs, that gives you all the differences required to run Windows containers, and can go into details in depth.
Maybe under Guides ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markmandel - does that mean that we should assume that for getting started folks are primarily using linux VMs? If we go that route, we should add a note here with a link to the windows game server guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thought is that folks may skip this getting started page completely and jump to https://agones.dev/site/docs/getting-started/create-fleet/ which says "While not required, you may wish to go through the Create a Game Server quickstart before this one." Rather than update both the game server and fleet getting started pages to have two paths, having them both link to a guide about windows game servers might be a better flow for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the above should be wrapped in a
feature
shortcode for the next release, since it won't be available until 1.14.0. (https://agones.dev/site/docs/contribute/#within-a-page)Do we also want to stage windows support somehow? I don't think we can feature flag it, but maybe some docs that it's alpha - as we don't 100% know how well it will perform at this stage?