Add Windows containers examples and docs. #2047
Conversation
|
Build Failed 😱 Build Id: 4e21bb4f-6ed3-47ad-9cc4-2afced118d01 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 8020a830-52bb-4d35-aaa5-f3dea7546b20 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jeremyje The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Failed 😱 Build Id: 345a69a0-3468-467e-b904-231302c6e1b8 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: bae1b368-b970-4416-9713-51f3a418562c To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
| kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/{{< release-branch >}}/examples/simple-game-server/gameserver.yaml | ||
| # Windows Game Server |
There was a problem hiding this comment.
This is a quickstart -- I'm not sure if we want to mix in the Linux vs Windows container discussion at this point, since this section is more about getting started quickly. WDYT @roberthbailey ?
I would argue it likely makes more sense to have a separate "Windows game server" guide somewhere in the docs, that gives you all the differences required to run Windows containers, and can go into details in depth.
Maybe under Guides ?
There was a problem hiding this comment.
@markmandel - does that mean that we should assume that for getting started folks are primarily using linux VMs? If we go that route, we should add a note here with a link to the windows game server guide.
There was a problem hiding this comment.
Another thought is that folks may skip this getting started page completely and jump to https://agones.dev/site/docs/getting-started/create-fleet/ which says "While not required, you may wish to go through the Create a Game Server quickstart before this one." Rather than update both the game server and fleet getting started pages to have two paths, having them both link to a guide about windows game servers might be a better flow for users.
| @@ -121,6 +124,19 @@ Flag explanations: | |||
| * node-labels: The Kubernetes labels to automatically apply to nodes in this node pool. | |||
| * num-nodes: The Agones system controllers only require a single node of capacity to run. For faster recovery time in the event of a node failure, you can increase the size to 2. | |||
|
|
|||
| _Optional_: Create a dedicated Windows node pool for game servers. If you need to run game servers on Windows you'll | |||
There was a problem hiding this comment.
This and the above should be wrapped in a feature shortcode for the next release, since it won't be available until 1.14.0. (https://agones.dev/site/docs/contribute/#within-a-page)
Do we also want to stage windows support somehow? I don't think we can feature flag it, but maybe some docs that it's alpha - as we don't 100% know how well it will perform at this stage?
|
Was going to update this to |
|
Closing in favor of #2065. |
* Copy of #2047. * Add a Guide for running windows game servers. Refactor some common prerequisites into a shortcode.
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
This change adds documentation and examples for creating a Windows cluster on GKE and running a Game server on a Windows node.
Which issue(s) this PR fixes:
Issue #54
Special notes for your reviewer:
This change requires a rebuild simple-game-server to work.