Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate java-shared-config to sdk-platform-java-config #1679

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

mpeddada1
Copy link
Contributor

Follow up to #1523.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@mpeddada1 mpeddada1 requested review from a team as code owners August 21, 2024 21:22
@mpeddada1 mpeddada1 requested a review from gkevinzheng August 21, 2024 21:22
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 21, 2024
@mpeddada1 mpeddada1 requested a review from cindy-peng August 21, 2024 21:22
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Aug 21, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 22, 2024
@mpeddada1 mpeddada1 merged commit b354532 into main Aug 22, 2024
23 checks passed
@mpeddada1 mpeddada1 deleted the consolidate-configs branch August 22, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants