Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove direct dependency on google-cloud-shared-config #1561

Closed
zhumin8 opened this issue Mar 18, 2024 · 3 comments
Closed

Chore: remove direct dependency on google-cloud-shared-config #1561

zhumin8 opened this issue Mar 18, 2024 · 3 comments
Assignees
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Mar 18, 2024

Regarding this #1550
remove this direct dependency so that this repo only needs sdk-platform-java-config dependency.

cc. @diegomarquezp @blakeli0

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Mar 18, 2024
@diegomarquezp
Copy link
Contributor

Hi @zhumin8, a couple of quick questions. Should this be part of the current release cycle? Why is google-cloud-shared-config unnecessary compared to sdk-platform-java-config?

@cindy-peng
Copy link
Contributor

Hi @zhumin8, I am also wondering the reason for removing this direct dependency. Could you help us understand why it is unnecessary and it is safe to remove google-cloud-shared-config?

@cindy-peng cindy-peng added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Sep 3, 2024
@zhumin8
Copy link
Contributor Author

zhumin8 commented Sep 5, 2024

@cindy-peng sorry for the delay, this message fall through the cracks and I just noticed it.

So sdk-platform-java-config consolidates configs from google-cloud-shared-config and hosts the google-cloud-shared-dependencies version under the google-cloud-shared-dependencies.version property.
That said, this issue is obsolete as I see #1679 recently made the change.

@zhumin8 zhumin8 closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Development

No branches or pull requests

3 participants