Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use sdk-platform-shared-config to consolidate build configs #1523

Merged
merged 6 commits into from
Jan 31, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Jan 29, 2024

Notable Changes:

  1. Use gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform* docker images for Kokoro GraalVM tests instead of gcr.io/cloud-devrel-kokoro-resources/graalvm*.
  2. Use com.google.cloud:sdk-platform-java-config as the parent which inherits configs from java-shared-config and hosts the google-cloud-shared-dependencies version under the google-cloud-shared-dependencies.version property. This artifact is versioned to be the same as google-cloud-shared-dependencies.
  3. Adjust renovate-bot settings to update docker images when a new version of sdk-platfrom-java-config is on Maven Central.

Example renovate-bot update PR in google-cloud-java: googleapis/google-cloud-java#10290

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 29, 2024
Copy link

Warning: This pull request is touching the following templated files:

  • renovate.json

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jan 29, 2024
@mpeddada1 mpeddada1 marked this pull request as ready for review January 29, 2024 19:21
@mpeddada1 mpeddada1 requested review from a team as code owners January 29, 2024 19:21
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jan 31, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 31, 2024
@mpeddada1 mpeddada1 merged commit ef92d48 into main Jan 31, 2024
23 checks passed
@mpeddada1 mpeddada1 deleted the atomic-updates-graalvm branch January 31, 2024 15:56
mpeddada1 added a commit that referenced this pull request Aug 21, 2024
mpeddada1 added a commit that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants