Update questionnaire buttons in xml fragment #2384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MJ1998
requested changes
Dec 21, 2023
sharon2719
force-pushed
the
questionnaire-content-customization
branch
from
d56b1c7 to
29150cc
Compare
|
@MJ1998 Update has been made |
|
Thanks. Please add a description to the solution! |
|
@MJ1998 I did further testing and noted that if the |
|
You are right! My IDE was throwing some error. After invalidate-restart its good. |
10 tasks
11 tasks
|
@MJ1998 Kindly prompt kokoro |
jingtang10
reviewed
Feb 6, 2024
* Add fhirpath supplements * Add unit tests * Update datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt Co-authored-by: Jing Tang <[email protected]> * Update datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt Co-authored-by: Jing Tang <[email protected]> * Resolve feedback and test issues * Fix compile issue * Update datacapture/src/test/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluatorTest.kt Co-authored-by: Jing Tang <[email protected]> * Rename tests --------- Co-authored-by: Jing Tang <[email protected]>
sharon2719
force-pushed
the
questionnaire-content-customization
branch
from
b76cef5 to
be1bcb2
Compare
jingtang10
approved these changes
Feb 13, 2024
santosh-pingle
previously requested changes
Feb 13, 2024
Co-authored-by: santosh-pingle <[email protected]>
Co-authored-by: santosh-pingle <[email protected]>
|
Build fails on spotless apply. |
auto-merge was automatically disabled
February 14, 2024 12:34
Head branch was pushed to by a user without write access
sharon2719
force-pushed
the
questionnaire-content-customization
branch
from
70e9cbe to
c2c78ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2353
Description
The
submitbutton has been made configurable and the layout can be changed based on one's use case. The rest of the buttonsprevious,nextandreviewhave also been made configurable as well based on the designs in the issue above.Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one:Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.