Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Styling update to lists #2887

Open
8 of 10 tasks
Rkareko opened this issue Nov 28, 2023 · 5 comments
Open
8 of 10 tasks

[UX] Styling update to lists #2887

Rkareko opened this issue Nov 28, 2023 · 5 comments

Comments

@Rkareko
Copy link
Contributor

Rkareko commented Nov 28, 2023

Describe the feature request.

New styling update to lists to resolve the issue of FABs overlaying the last item in the list have been added. These properties can be found when you select the list container. Do confirm with designs for each and every list or screen (feel free to reach out to @HenryRae incase of anything)

  • All lists if using FAB should have 80px bottom padding.
  • Lists without FAB will have different padding properties(32px or 24px - as per the design)

Affected lists

Fix main content padding on various screens #2892 tracks fixes for the following

Styling update to forms #2910 tracks the fix for the following

Implementation plan (For Engineers)
The plan for implementing the solution e.g. via a description or a check list for the various ordered tasks that will need to be completed.
i.e. Describe how you intend to solve the problem

@ellykits
Copy link
Collaborator

Issue related to #2821

@Rkareko
Copy link
Contributor Author

Rkareko commented Nov 29, 2023

@f-odhiambo @dubdabasoduba The following changes can only be implemented in the the SDC library

Filter options - (bottom padding/margin 24px)

All Forms - (bottom n top padding/margin 24px)

@pld
Copy link
Member

pld commented Nov 30, 2023

@f-odhiambo @dubdabasoduba The following changes can only be implemented in the the SDC library

Filter options - (bottom padding/margin 24px)

All Forms - (bottom n top padding/margin 24px)

K, let's split those out to a separate issue in fhircore, and also create an issue the Android FHIR SDK to make that configurable with defaults at whatever it currently is

@Rkareko
Copy link
Contributor Author

Rkareko commented Dec 1, 2023

K, let's split those out to a separate issue in fhircore, and also create an issue the Android FHIR SDK to make that configurable with defaults at whatever it currently is

I propose that these changes be added as part of the [UX] Adjustments and Updates to widgets on Questionnaire ticket cc @f-odhiambo @dubdabasoduba @pld

@Rkareko
Copy link
Contributor Author

Rkareko commented Jan 22, 2024

@f-odhiambo There is a pending PR Questionnaire content style customization #2353 by @sharon2719 that addresses the padding on the button in the Questionnaire screens.

@ndegwamartin ndegwamartin changed the title Styling update to lists [UX] Styling update to lists Jan 22, 2024
@ndegwamartin ndegwamartin assigned HenryRae and unassigned Rkareko Jan 29, 2024
@ndegwamartin ndegwamartin removed this from the Sprint 2 (Jan 14th- Jan 26th) milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants