Merge pull request #51 from gnosis/fix-tx-translation-check

fix: check if tx is eligible for translation
gnosisguild · Jan 18, 2023 · 72ee07a · 72ee07a
2 parents f4de141 + 2a6bbe7
commit 72ee07a
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/extension/src/transactionTranslations/uniswapMulticall.ts b/extension/src/transactionTranslations/uniswapMulticall.ts
@@ -15,7 +15,9 @@ export default {
   recommendedFor: [KnownContracts.ROLES],
 
   translate: (transaction) => {
-    if (!transaction.data) return [transaction]
+    if (!transaction.data) {
+      return undefined
+    }
 
     let functionCalls: string[] = []
     for (const fragment of uniswapMulticallInterface.fragments) {
@@ -31,10 +33,10 @@ export default {
       }
     }
 
-    if (functionCalls.length > 0) {
-      return functionCalls.map((data) => ({ ...transaction, data }))
+    if (functionCalls.length === 0) {
+      return undefined
     }
 
-    return [transaction]
+    return functionCalls.map((data) => ({ ...transaction, data }))
   },
 } satisfies TransactionTranslation