fix: undefined if tx not eligible for translation

gnosisguild · Jan 17, 2023 · 2a6bbe7 · 2a6bbe7
1 parent 9b37cca
commit 2a6bbe7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/extension/src/transactionTranslations/index.ts b/extension/src/transactionTranslations/index.ts
@@ -9,11 +9,7 @@ export const findApplicableTranslation = (
   transaction: MetaTransaction
 ): TransactionTranslation | undefined => {
   for (const translation of translations) {
-    try {
-      if (translation.translate(transaction)) return translation
-    } catch (e) {
-      continue
-    }
+    if (translation.translate(transaction)) return translation
   }
   return undefined
 }
diff --git a/extension/src/transactionTranslations/uniswapMulticall.ts b/extension/src/transactionTranslations/uniswapMulticall.ts
@@ -16,7 +16,7 @@ export default {
 
   translate: (transaction) => {
     if (!transaction.data) {
-      throw Error("Invalid translation: transaction doesn't have data")
+      return undefined
     }
 
     let functionCalls: string[] = []
@@ -34,7 +34,7 @@ export default {
     }
 
     if (functionCalls.length === 0) {
-      throw Error("Invalid translation: couldn't decode function data")
+      return undefined
     }
 
     return functionCalls.map((data) => ({ ...transaction, data }))