fix: check if tx is eligible for translation

gnosisguild · Jan 17, 2023 · 9b37cca · 9b37cca
1 parent f4de141
commit 9b37cca
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/extension/src/transactionTranslations/index.ts b/extension/src/transactionTranslations/index.ts
@@ -9,7 +9,11 @@ export const findApplicableTranslation = (
   transaction: MetaTransaction
 ): TransactionTranslation | undefined => {
   for (const translation of translations) {
-    if (translation.translate(transaction)) return translation
+    try {
+      if (translation.translate(transaction)) return translation
+    } catch (e) {
+      continue
+    }
   }
   return undefined
 }
diff --git a/extension/src/transactionTranslations/uniswapMulticall.ts b/extension/src/transactionTranslations/uniswapMulticall.ts
@@ -15,7 +15,9 @@ export default {
   recommendedFor: [KnownContracts.ROLES],
 
   translate: (transaction) => {
-    if (!transaction.data) return [transaction]
+    if (!transaction.data) {
+      throw Error("Invalid translation: transaction doesn't have data")
+    }
 
     let functionCalls: string[] = []
     for (const fragment of uniswapMulticallInterface.fragments) {
@@ -31,10 +33,10 @@ export default {
       }
     }
 
-    if (functionCalls.length > 0) {
-      return functionCalls.map((data) => ({ ...transaction, data }))
+    if (functionCalls.length === 0) {
+      throw Error("Invalid translation: couldn't decode function data")
     }
 
-    return [transaction]
+    return functionCalls.map((data) => ({ ...transaction, data }))
   },
 } satisfies TransactionTranslation