Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Dockerfile #237

Closed
wants to merge 1 commit into from
Closed

Conversation

bgruening
Copy link

Seems that the latest version is not working with openjdk:8 anymore.
We got a:

Unrecognized option: --add-opens
Error: Could not create the Java Virtual Machine.

Seems that the latest version is not working with openjdk:8 anymore.

> Unrecognized option: --add-opens
Error: Could not create the Java Virtual Machine.
@melissalinkert
Copy link
Member

Thanks for bringing this up, @bgruening.

As described in #239, removing support for JDK 8 was unintentional; my apologies for the inconvenience. The new 0.9.1 release should support JDK 8 again, so closing this as it should no longer be necessary. If you still see an issue with 0.9.1 though, please do let us know.

@bgruening
Copy link
Author

Thanks for fixing it. I'm happy to close this PR. But maybe it's useful to update gradle and openjdk - which on its own is deprecated?

@sbesson
Copy link
Member

sbesson commented Jan 24, 2024

@bgruening The Gradle version is definitely outdated as the build currently happens on Gradle 7.3.3 as defined in gradle/wrapper. As for the OpenJDK version, the library currently supports Java 8, 11 & 17 and there is currently no active plan to drop either of them.

The disconnect partly comes from the fact that none of us, certainly neither @melissalinkert nor myself, use the Dockerfile as part of our development workflow. This means the Dockerfile will go out-of-date and probably raises the wider question of whether there is still a rationale/motivation for maintaining this workflow in this repository or if it should be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants