Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for illegal access warnings #239

Open
melissalinkert opened this issue Jan 22, 2024 · 0 comments
Open

Better fix for illegal access warnings #239

melissalinkert opened this issue Jan 22, 2024 · 0 comments

Comments

@melissalinkert
Copy link
Member

61fcc36 reverts the addition of --add-opens to the default JVM options in #233. As noted in #233 (comment) and #237, that change breaks JDK 8 support.

The revert and subsequent release of 0.9.1 was the quickest way to resolve this in the short term; 0.9.1 is expected to work with JDK 8+. However, it would be still be nice to remove illegal access warnings going forward.

As @chris-allan mentioned separately, setting JDK_JAVA_OPTIONS is probably the path forward. I need a little more time to figure out how best to implement that though, and we'll want to test on a variety of platforms. @sbesson also mentioned this might be a good occasion to figure out a way to automatically test the zip; that's maybe a separate step in .github./workflows/build.yml

@melissalinkert melissalinkert moved this from Inbox to bioformats2raw 0.9.2 in Converters Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: bioformats2raw 0.9.2
Development

No branches or pull requests

2 participants
@melissalinkert and others