Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dépôt de besoin] Nouveau status "SENT" #997

Merged
merged 6 commits into from
Dec 6, 2023

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Nov 30, 2023

Quoi ?

  • nouveau Tender.status SENT qui arrive après VALIDATED
  • nouveau champ Tender.sent_at
  • la migration populate correctement ces 2 modifications

Pour l'instant il est mis à jour en même temps car la logique n'a pas été changée (envoi au moment de la validation) - cela interviendra dans la prochaine PR.

J'ai mis à jour la logique et les tests pour basculer les besoins "visibles" de validés à envoyés.

@raphodn raphodn self-assigned this Nov 30, 2023
@raphodn raphodn changed the title [Dépôt de besoin] Nouveau status Envoyé [Dépôt de besoin] Nouveau status "SENT" Nov 30, 2023
@raphodn raphodn force-pushed the raphodn/tender-status-sent branch 4 times, most recently from f68c1df to 009ca22 Compare December 1, 2023 10:10
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Ce n'est pas anodin comme modif, bien joué ! 👏

@raphodn raphodn force-pushed the raphodn/tender-status-sent branch 2 times, most recently from 83aac2d to 4dd020e Compare December 6, 2023 12:12
@raphodn raphodn force-pushed the raphodn/tender-status-sent branch from 4dd020e to bcabdbb Compare December 6, 2023 12:28
@raphodn raphodn merged commit c457fb2 into master Dec 6, 2023
4 checks passed
@raphodn raphodn deleted the raphodn/tender-status-sent branch December 6, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants