[Dépôt de besoin] Envoyer en asynchrone les besoins validés #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
force-pushed
the
raphodn/tender-status-sent
branch
3 times, most recently
from
f68c1df to
009ca22
Compare
raphodn
force-pushed
the
raphodn/tender-send-with-cron
branch
from
084501a to
6be2f87
Compare
SebastienReuiller
approved these changes
Dec 5, 2023
| if settings.BITOUBI_ENV == "prod": | ||
| api_hubspot.create_deal_from_tender(tender=obj) | ||
| obj.set_validated() | ||
| self.message_user(request, "Ce dépôt de besoin a été validé. Il sera envoyé en temps voulu :)") |
| # Send Tenders who are validated but not sent | ||
|
|
||
| # Do not run if this env var is not set: | ||
| if [[ -z "$CRON_TENDER_SEND_VALIDATED_ENABLED" ]]; then |
There was a problem hiding this comment.
J'adore cette possibilité de débrayer !
There was a problem hiding this comment.
seul hic, c'est qu'il n'y a pas d'option intermédiaire (désactiver le cron mais permettre l'envoi manuel 🤔 )
raphodn
force-pushed
the
raphodn/tender-status-sent
branch
3 times, most recently
from
4dd020e to
bcabdbb
Compare
raphodn
force-pushed
the
raphodn/tender-send-with-cron
branch
from
f73a3fd to
0c196af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite de #997
Quoi ?
Les besoins validés via l'admin ne sont plus envoyés automatiquement.
C'est cette nouvelle management commande
send_validated_tendersqui sera chargée de le faire.Ajout dans le cron avec
*/5 9-17 * * 1-5= Every 5 minutes from 9am through 5pm on Monday through Fridayhttps://cron.help/#*/5_9-17_*_*_1-5