Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : Use uv to resolve dependencies #226

Merged
merged 4 commits into from
Apr 22, 2024
Merged

chore : Use uv to resolve dependencies #226

merged 4 commits into from
Apr 22, 2024

Conversation

vperron
Copy link
Contributor

@vperron vperron commented Apr 18, 2024

https://github.com/astral-sh/uv

And another Makefile, for extra fast and efficient updates,

@vperron vperron self-assigned this Apr 18, 2024
@vperron vperron requested a review from vmttn as a code owner April 18, 2024 13:48
Copy link
Contributor

@vmttn vmttn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah lovely! t'as time pour voir ce que ça donne quoi avant/après ?

@@ -1,6 +1,6 @@
# pip-compile~=7.3

PIP_COMPILE := pip-compile --quiet
PIP_COMPILE := uv pip compile --quiet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipx run uv ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour de ne pas installer uv sur le system python par mégarder

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • figer la version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, j'avoue je pars toujours du principe que on est dans un venv quoi qu'il arrive. ^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm ... pipx run uv pip compile ?? ^^ 🤤

@vperron
Copy link
Contributor Author

vperron commented Apr 18, 2024

Sur pipeline: time make upgrade all

Before

real    0m55,193s
user    0m42,995s
sys     0m2,214s

After

real    0m2,613s
user    0m2,064s
sys     0m0,465s

@vperron
Copy link
Contributor Author

vperron commented Apr 22, 2024

Corrigé les points que tu avais soulevé.

@vperron vperron merged commit f609332 into main Apr 22, 2024
6 checks passed
@vperron vperron deleted the vperron/uv branch April 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants