Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new alert that fires if etcd backup metrics are missing for 12h. #946

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Add new alert that fires if etcd backup metrics are missing for 12h. #946

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
65449c2
Add new alert that fires if etcd backup metrics are missing for 12h.
whites11 Nov 9, 2023
9265af0
Add new alert that fires if etcd backup metrics are missing for 12h.
whites11 Nov 9, 2023
3cf3857
Merge branch 'master' into etcd-backup
whites11 Nov 13, 2023
59343f3
Update etcdbackup.rules.yml
whites11 Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add new alert that fires if etcd backup metrics are missing for 12h.

## [2.139.0] - 2023-11-07

### Added
Expand Down
12 changes: 12 additions & 0 deletions helm/prometheus-rules/templates/alerting-rules/etcdbackup.rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,3 +68,15 @@ spec:
severity: page
team: {{ include "providerTeam" . }}
topic: etcd-backup
- alert: ETCDBackupMetricsMissing
annotations:
description: '{{`ETCD backup metrics are missing`}}'
opsrecipe: etcd-backup-failed/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to add a new section to the recipe, explaining that the metrics are exposed by the controller, so the oncaller needs to check the deployment status.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/giantswarm/giantswarm/pull/28825/files

expr: absent(etcd_backup_latest_attempt)
for: 12h
labels:
area: kaas
cancel_if_outside_working_hours: "true"
severity: page
team: {{ include "providerTeam" . }}
topic: etcd-backup