Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new alert that fires if etcd backup metrics are missing for 12h. #946

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

whites11
Copy link
Contributor

@whites11 whites11 commented Nov 9, 2023

Towards: https://github.com/giantswarm/giantswarm/issues/28783

This PR adds a new alert that pages if etcd backup operator metrics are not present in a MC

Checklist

@whites11 whites11 requested a review from a team as a code owner November 9, 2023 15:00
@whites11 whites11 self-assigned this Nov 9, 2023
@whites11 whites11 requested review from a team November 9, 2023 15:15
- alert: ETCDBackupMetricsMissing
annotations:
description: '{{`ETCD backup metrics are missing`}}'
opsrecipe: etcd-backup-failed/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be best to add a new section to the recipe, explaining that the metrics are exposed by the controller, so the oncaller needs to check the deployment status.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whites11
Copy link
Contributor Author

waiting for opsrecipe to be merged before I merge this one

@whites11 whites11 merged commit 0002f27 into master Nov 13, 2023
4 checks passed
@whites11 whites11 deleted the etcd-backup branch November 13, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants