Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MimirContinuousTestFailingOnWrites and MimirContinuousTestFailing… #1355

Merged
merged 15 commits into from
Nov 15, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

Towards: giantswarm/roadmap#3578

As discussed in the above issue, this PR adds 2 alerts based on the mimir's continous-test component's metrics so that we get alerted when something is wrong in the read or write path.

Those 2 alerts are directly taken from upstream mixins as explained in the comments.

Before merging this PR, I still need to add UTs as well as create a dedicated dashboard for the continous-test component.

Checklist

@QuantumEnigmaa QuantumEnigmaa self-assigned this Sep 10, 2024
@QuentinBisson QuentinBisson marked this pull request as ready for review November 12, 2024 14:15
@QuentinBisson QuentinBisson requested a review from a team as a code owner November 12, 2024 14:15
@QuentinBisson
Copy link
Contributor

This is not a draft anymore, I repeat, this is not a draft anymore

@QuentinBisson QuentinBisson force-pushed the add-mimir-continoustest-alerts branch from 7837d81 to 5d3aa9e Compare November 12, 2024 14:23
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, we're testing the rate of fails, which is fine.
But the continuous tests also provide a counter of reads and writes. Should we test those as well?

For instance, if we can't write data, we won't get any fails increase. But we also won't get any count of new "continuous test writes", which should probably raise an alert?

@QuentinBisson QuentinBisson force-pushed the add-mimir-continoustest-alerts branch from 8799704 to 4963d56 Compare November 12, 2024 16:21
@QuentinBisson QuentinBisson enabled auto-merge (squash) November 14, 2024 17:28
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note (to self): I'm not happy about the duplicate tests for CAPI. CAPI should now be the default target for tests, and vintage/aws the exception.

@QuentinBisson QuentinBisson merged commit 9b485cd into main Nov 15, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the add-mimir-continoustest-alerts branch November 15, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants