-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mimir continous test dashboard #624
Conversation
How can we have a |
Does it mean this PR should be set as draft for now, and is not ready for review yet? |
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
], | ||
"refresh": "", | ||
"schemaVersion": 39, | ||
"tags": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the same tags as the other mimir dashboards?
"fiscalYearStartMonth": 0, | ||
"graphTooltip": 0, | ||
"id": 143, | ||
"links": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need the same as
I deployed this on golem and the metrics are fine so this is not a draft anymore. @TheoBrigitte what do you mean with your idea? Currently used metrics are defined here https://grafana.com/docs/mimir/latest/manage/tools/mimir-continuous-test/#exported-metrics if that helps |
…/private/mimir-continuous-tests.json
I added missing tags so it's up for reviews |
Did these metrics get fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you've set a rate
it's not total
anymore.
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
...ashboards/charts/private_dashboards_mz/dashboards/shared/private/mimir-continuous-tests.json
Outdated
Show resolved
Hide resolved
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json Co-authored-by: Hervé Nicol <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I guess it will live and evolve when we actually use it then!
Towards giantswarm/roadmap#3578 and related to https://github.com/giantswarm/shared-configs/pull/149 and giantswarm/prometheus-rules#1355
This PR adds a
Mimir / Continous test
dashboard to display themimir-continous-test
component's metrics and have an overview of the current general Health of mimir.There's an issue though as when I deployed the continuous-test component on
grizzly
the "failed" metrics for bothqueries
andwrites
were missing while they are defined and referred to upstream. So before merging this, we need to get those metrics back.Otherwise, here is the dahboard's current look :
Checklist