Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mimir continous test dashboard #624

Merged
merged 13 commits into from
Nov 12, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa commented Sep 10, 2024

Towards giantswarm/roadmap#3578 and related to https://github.com/giantswarm/shared-configs/pull/149 and giantswarm/prometheus-rules#1355

This PR adds a Mimir / Continous test dashboard to display the mimir-continous-test component's metrics and have an overview of the current general Health of mimir.

There's an issue though as when I deployed the continuous-test component on grizzly the "failed" metrics for both queries and writes were missing while they are defined and referred to upstream. So before merging this, we need to get those metrics back.

Otherwise, here is the dahboard's current look :

image

Checklist

  • Update changelog in CHANGELOG.md in an end-user friendly language.

@QuantumEnigmaa QuantumEnigmaa self-assigned this Sep 10, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner September 10, 2024 13:07
@TheoBrigitte
Copy link
Member

How can we have a 0.06 as value for Total queries test and other ? I read that as the number of queries tested, did I read this wrong ? Maybe we need a panel to explain what those values are.

@hervenicol
Copy link
Contributor

So before merging this, we need to get those metrics back.

Does it mean this PR should be set as draft for now, and is not ready for review yet?

CHANGELOG.md Outdated Show resolved Hide resolved
],
"refresh": "",
"schemaVersion": 39,
"tags": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the same tags as the other mimir dashboards?

"fiscalYearStartMonth": 0,
"graphTooltip": 0,
"id": 143,
"links": [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuentinBisson
Copy link
Contributor

I deployed this on golem and the metrics are fine so this is not a draft anymore.

@TheoBrigitte what do you mean with your idea?

Currently used metrics are defined here https://grafana.com/docs/mimir/latest/manage/tools/mimir-continuous-test/#exported-metrics if that helps

@QuentinBisson
Copy link
Contributor

I added missing tags so it's up for reviews

@hervenicol
Copy link
Contributor

There's an issue though as when I deployed the continuous-test component on grizzly the "failed" metrics for both queries and writes were missing while they are defined and referred to upstream. So before merging this, we need to get those metrics back.

Did these metrics get fixed?
Maybe the screenshot should be updated then?

@QuentinBisson
Copy link
Contributor

Here you go
image

Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've set a rate it's not total anymore.

QuentinBisson and others added 7 commits November 12, 2024 15:22
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
…/private/mimir-continuous-tests.json

Co-authored-by: Hervé Nicol <[email protected]>
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I guess it will live and evolve when we actually use it then!

@QuentinBisson QuentinBisson merged commit 29113c5 into main Nov 12, 2024
4 checks passed
@QuentinBisson QuentinBisson deleted the add-mimir-continoustest-dashboard branch November 12, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants