Add mimir mixins with correct cluster label #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
add-mimir-mixins-recording-rules
branch
from
e19d743 to
27f4777
Compare
5 tasks
Signed-off-by: QuentinBisson <[email protected]>
QuentinBisson
force-pushed
the
add-mimir-mixins-recording-rules
branch
from
27f4777 to
7294778
Compare
|
Towards https://github.com/giantswarm/giantswarm/issues/30310 @giantswarm/team-atlas could you take a look at this? This PR adds and fixes (with pint) the mimir recording rules |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: giantswarm/dashboards#510
This PR is needed by giantswarm/dashboards#510 so dashboards that use the rules actually work. Current implementation is not ideal. I would rather we add those to the mimir-app but let's test it here for now
Checklist
oncall-kaas-cloudGitHub group).