-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all kubenetes mixins according to pint #1178
Conversation
Have upstream mixins been updated accordingly? So next time we upgrade we don't have to re-apply all these changes? |
Which ones ? The Kubernetes ones most likely not. Thé Loki and Mimir ones nope but that's s in other PRs and it's sadly not ready yet anyway |
The kubernetes mixin script was updated but for loki and mimir it's currently not merged |
@hervenicol I added the upgrade scripts to add the labels using sed in #1131 for both loki and mimir and for the kubernetes mixins in this PR. The loki and mimir scripts added in #1131 will eventually be moved to the mimir and loki app (end goal of https://github.com/giantswarm/giantswarm/issues/30309 and https://github.com/giantswarm/giantswarm/issues/30310 once we upgraded to loki 3 and ongoing issues are fixed) It also needs giantswarm/dashboards#538 to be merged which renames all cluster occurences to cluster_id as recording rules are generated like that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: https://github.com/giantswarm/...
This PR fixes mixins according to basic pint recommendations
Checklist
oncall-kaas-cloud
GitHub group).