Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all kubenetes mixins according to pint #1178

Merged
merged 5 commits into from
May 15, 2024
Merged

Fix all kubenetes mixins according to pint #1178

merged 5 commits into from
May 15, 2024

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR fixes mixins according to basic pint recommendations

Checklist

@QuentinBisson QuentinBisson self-assigned this May 14, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner May 14, 2024 12:05
@hervenicol
Copy link
Contributor

Have upstream mixins been updated accordingly? So next time we upgrade we don't have to re-apply all these changes?

@QuentinBisson
Copy link
Contributor Author

Which ones ? The Kubernetes ones most likely not. Thé Loki and Mimir ones nope but that's s in other PRs and it's sadly not ready yet anyway

@QuentinBisson
Copy link
Contributor Author

The kubernetes mixin script was updated but for loki and mimir it's currently not merged

@QuentinBisson
Copy link
Contributor Author

QuentinBisson commented May 14, 2024

@hervenicol I added the upgrade scripts to add the labels using sed in #1131 for both loki and mimir and for the kubernetes mixins in this PR.

The loki and mimir scripts added in #1131 will eventually be moved to the mimir and loki app (end goal of https://github.com/giantswarm/giantswarm/issues/30309 and https://github.com/giantswarm/giantswarm/issues/30310 once we upgraded to loki 3 and ongoing issues are fixed)

It also needs giantswarm/dashboards#538 to be merged which renames all cluster occurences to cluster_id as recording rules are generated like that

@QuentinBisson QuentinBisson changed the title Fix all mixins according to pint Fix all kubenetes mixins according to pint May 15, 2024
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@marieroque marieroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit 762f278 into master May 15, 2024
6 checks passed
@QuentinBisson QuentinBisson deleted the fix-mixins branch May 15, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants