rename prometheus-agent inbitions to monitoring agent to be able to take alloy into account #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
This has to be synchronized with a change of labels on prometheus-rules, right? |
|
Oh, found the prometheus-rules PR here: giantswarm/prometheus-rules#1405 I wonder what will happen when releasing these, and whether it we need a deployment plan or a phased deployment? |
|
Yes I Linked this PR in the rules. I think the only thing we Can do is merge this and prometheus and sloth rules at the same time |
|
Well, we could have a non-breaking phased deployment that would do:
This would ensure we don't have a moment with no inhibitions and clusters firing lots of alerts. |
|
Sure. I'll create the pr tomorrow then |
…ake alloy into account
QuentinBisson
force-pushed
the
rename-prometheus-agent-to-monitoring-agent-inhibition
branch
from
489ee70 to
2b8389f
Compare
|
@hervenicol as requested, I added new inhibitions to have a seamless upgrade |
QuentinBisson
deleted the
rename-prometheus-agent-to-monitoring-agent-inhibition
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards giantswarm/roadmap#3590.
We now use alloy as a monitoring agent so having the inhibition named prometheus-agent makes no sense.
This PR renames both inbititions about missing prometheus agent to monitoring agent.
Checklist
I have:
CHANGELOG.md