Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless prometheus-agent inhibitions as they were replaced #1758

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

QuentinBisson
Copy link
Contributor

Checklist

This PR gets rid of the old prometheus-agent inhibitions as they were replaced by monitoring-agent inhibitions #1753 and used in alerts giantswarm/prometheus-rules#1405 and sloth alerts https://github.com/giantswarm/sloth-rules/pull/253 which were both released :)

I have:

  • Described why this change is being introduced
  • Separated out refactoring/reformatting in a dedicated PR
  • Updated changelog in CHANGELOG.md

@QuentinBisson QuentinBisson self-assigned this Oct 30, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner October 30, 2024 15:52
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit 2893506 into main Oct 31, 2024
5 checks passed
@QuentinBisson QuentinBisson deleted the remove-legacy-prometheus-agent-inhibitions branch October 31, 2024 18:55
@TheoBrigitte TheoBrigitte mentioned this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants