-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a local run tool for dev purposes #202
Conversation
I love it <3 <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea but running outside the cluster makes internal network not reachable, for instance I can't test my Alertmanager controller because it needs to talk to mimir-alertmanager-headless.mimir.svc
Would you be fine to try a different approach where we replace the docker image in the deployment in order to run it in the cluster ? |
ef9b134
to
32ebe92
Compare
That requires extra steps:
I'm not sure these extra steps are worth it (especially authenticating on the registry, and making sure we change the image tag - which then implies doing some cleanup for old images). If your use case is the alertmanager access, why not doing it with a port forward like grafana access? |
We could use the $USER name to tag the image which make it easy to clean it up afterward. Port forward would not work as I cannot resolve |
All right, I see we have the same behaviour / issue with grafana. Somehow I just checked that the operator was starting and running, but didn't check its actual behaviour and error messages 🤦 I think we should have these parameters (dependencies URLs/ports) as user-definable parameters. |
32ebe92
to
6060829
Compare
6060829
to
206a670
Compare
So, now it's working, and you can add the alertmanager setup when available @TheoBrigitte . |
What this PR does / why we need it
This should improve dev experience, so we don't have to wait for the CI build.
Checklist