Urls config #210
Merged
Urls config #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
main.go
Outdated
| opts := zap.Options{ | ||
| Development: false, | ||
| } | ||
|
|
||
| opts.BindFlags(flag.CommandLine) | ||
| flag.Parse() | ||
|
|
||
| // parse grafana URL | ||
| conf.GrafanaURL, err = url.Parse(grafanaURLString) |
There was a problem hiding this comment.
Suggested change
| conf.GrafanaURL, err = url.Parse(grafanaURLString) | |
| conf.GrafanaURL, err = url.Parse(grafanaURL) |
main.go
Outdated
| @@ -63,6 +64,9 @@ func init() { | |||
| } | |||
|
|
|||
| func main() { | |||
| var grafanaURLString string | |||
There was a problem hiding this comment.
Suggested change
| var grafanaURLString string | |
| var grafanaURL string |
QuentinBisson
approved these changes
Dec 18, 2024
hervenicol
force-pushed
the
urls-config
branch
from
e9337ba to
950776f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #202
These addresses should not be hard-coded, this PR adds a way to override via command-line arguments.
What this PR does / why we need it
Checklist