support-multiple-tenants-in-one-org #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
support-multiple-tenants
branch
from
60d8e3a to
999bc3c
Compare
hervenicol
reviewed
Dec 10, 2024
config/crd/observability.giantswarm.io_grafanaorganizations.yaml
Outdated
Show resolved
Hide resolved
QuentinBisson
force-pushed
the
support-multiple-tenants
branch
from
999bc3c to
bb9e438
Compare
| @@ -0,0 +1,210 @@ | |||
| package predicates | |||
There was a problem hiding this comment.
I am confused, what have those test to do with the changes in this PR ?
There was a problem hiding this comment.
Nothing, I forgot to push it in an earlier PR
| @@ -224,14 +224,23 @@ func (r GrafanaOrganizationReconciler) configureSharedOrg(ctx context.Context) e | |||
| return nil | |||
| } | |||
|
|
|||
| func newOrganization(grafanaOrganization *v1alpha1.GrafanaOrganization) *grafana.Organization { | |||
There was a problem hiding this comment.
Would be best when this function return no pointer.
TheoBrigitte
approved these changes
Dec 10, 2024
QuentinBisson
force-pushed
the
support-multiple-tenants
branch
from
bb9e438 to
d9b3fa4
Compare
TheoBrigitte
approved these changes
Dec 10, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR adds support for multiple tenant in the grafana organization CRs to support multiple organizations on the read path for plaform teams and so on giantswarm/roadmap#3784
Checklist