Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto update mimir dashboards #510

Merged
merged 9 commits into from
Jun 5, 2024
Merged

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Apr 16, 2024

This PR

Checklist

  • Update changelog in CHANGELOG.md in an end-user friendly language.

@QuentinBisson QuentinBisson self-assigned this Apr 16, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner April 16, 2024 12:56
@QuentinBisson QuentinBisson force-pushed the auto-update-mimir-dashboards branch 2 times, most recently from 7e7c849 to 85c76c7 Compare April 16, 2024 13:00
@hervenicol
Copy link
Contributor

Do we have an issue in our board?
It looks like it also updates Loki dashboards, which is already in a PR here: #494

Beware of custom changes like:

@QuentinBisson QuentinBisson force-pushed the auto-update-mimir-dashboards branch from 85c76c7 to 854d44d Compare April 16, 2024 13:03
@QuentinBisson
Copy link
Contributor Author

We do have an issue which I added in the top description. I'm aware of the changes and I will check what we can to do add them here, either replacing them using jq, fix them properly upstream or in our setup :)

@QuentinBisson
Copy link
Contributor Author

I removed the loki changes, those were because my main branch was outdated

Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson force-pushed the auto-update-mimir-dashboards branch 2 times, most recently from bb2e5d1 to 9e8e348 Compare April 17, 2024 08:56
Signed-off-by: QuentinBisson <[email protected]>
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson force-pushed the auto-update-mimir-dashboards branch from 093336a to 76d3ab4 Compare April 17, 2024 15:25
@QuentinBisson
Copy link
Contributor Author

@QuentinBisson QuentinBisson force-pushed the auto-update-mimir-dashboards branch from 799d0c5 to 30f67c0 Compare June 5, 2024 21:33
@QuentinBisson
Copy link
Contributor Author

All dashboards are working as expected, merging 🎉

@QuentinBisson QuentinBisson merged commit c738653 into main Jun 5, 2024
4 checks passed
@QuentinBisson QuentinBisson deleted the auto-update-mimir-dashboards branch June 5, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants