Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script to update loki dashboards #494

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Add script to update loki dashboards #494

merged 6 commits into from
Sep 19, 2024

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Apr 10, 2024 •
edited
Loading

Towards https://github.com/giantswarm/giantswarm/issues/30309

This PR

  • adds a script to update the loki dashboard whenever we release a new version

Checklist

  • Update changelog in CHANGELOG.md in an end-user friendly language.

@QuentinBisson QuentinBisson self-assigned this Apr 10, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner April 10, 2024 23:43
QuantumEnigmaa
QuantumEnigmaa reviewed Apr 11, 2024
View reviewed changes
loki/update.sh Outdated

set -e

TAG="helm-loki-5.47.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be a way to have this configurable ? Something like TAG="helm-loki-$version" so that we can alwys use the latest veresion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my idea eventually but I'm no bash expert so I'm waiting for help

@hervenicol
Copy link
Contributor

I gave up on this one when I imported the dashboards, because there was simply too much to change.
Has it been updated upstream so we can write such a simple script for the upgrade now?

@QuentinBisson
Copy link
Contributor Author

From what i see yes, also, I'm removing the cluster label in favor of the cluster_id one

@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch 3 times, most recently from 8990c57 to 04ccff3 Compare April 11, 2024 10:09
QuentinBisson
QuentinBisson commented Apr 11, 2024
View reviewed changes
helm/dashboards/charts/private_dashboards_al/dashboards/shared/private/loki-logs.json Outdated
@@ -580,7 +582,7 @@
"steppedLine": false,
"targets": [
{
"expr": "increase(kube_pod_container_status_last_terminated_reason{cluster_id=\"$cluster_id\", namespace=\"$namespace\", pod=~\"$deployment.*\", pod=~\"$pod\", container=~\"$container\"}[30m]) > 0",
"expr": "increase(kube_pod_container_status_last_terminated_reason{cluster=\"$cluster\", namespace=\"$namespace\", pod=~\"$deployment.*\", pod=~\"$pod\", container=~\"$container\"}[30m]) > 0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafana/loki#12570 upstream fix

@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch 3 times, most recently from b6d8e13 to 97cdf30 Compare April 11, 2024 14:09
@hervenicol hervenicol mentioned this pull request Apr 16, 2024
Merged
1 task
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch from 97cdf30 to 35febac Compare April 16, 2024 19:46
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch 2 times, most recently from 6c14e17 to 42f7a2d Compare May 1, 2024 14:36
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch from 42f7a2d to 2d7890e Compare May 6, 2024 19:09
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch 4 times, most recently from 282034e to 7052a07 Compare May 23, 2024 07:33
@TheoBrigitte
Copy link
Member

What happened to this PR ? I believe it would be good to have it merged.

@QuentinBisson
Copy link
Contributor Author

I'm waiting for a lot of upstreams PRs to be fixed first :(

@TheoBrigitte
Copy link
Member

I'm waiting for a lot of upstreams PRs to be fixed first :(

Could you please link the PR we are waiting on so that we know when we can move ahead with this.

@QuentinBisson
Copy link
Contributor Author

I linked the issue and not the PR because we are waiting for a bunch of them

@QuentinBisson
Add script to update loki dashboards
76676e6 
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson
Use mixins
9079d28 
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson
regen
7bd0754 
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch from 7052a07 to d60a043 Compare September 18, 2024 20:01
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch 6 times, most recently from 7510771 to fa77a44 Compare September 19, 2024 09:51
@QuentinBisson QuentinBisson force-pushed the auto-update-loki-dashboards branch from cf55608 to cc4359e Compare September 19, 2024 10:02
@QuentinBisson
Copy link
Contributor Author

It is now deployed on grizzly and it works fine :)

@QuentinBisson
Copy link
Contributor Author

It covers all ongoign issues so I would love some eyes here @giantswarm/team-atlas

QuantumEnigmaa
QuantumEnigmaa approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson
Copy link
Contributor Author

Finally, damn

@QuentinBisson QuentinBisson merged commit 0fb5198 into main Sep 19, 2024
4 checks passed
@QuentinBisson QuentinBisson deleted the auto-update-loki-dashboards branch September 19, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuantumEnigmaa QuantumEnigmaa QuantumEnigmaa approved these changes

Assignees

@QuentinBisson QuentinBisson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@QuentinBisson @hervenicol @TheoBrigitte @QuantumEnigmaa