Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sRGB issues with glBlitFramebuffer on WGL #4273

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Oct 20, 2023

This fixes issues with glBlitFramebuffer inconsistently applying sRGB conversions between drivers and formats by disabling GL_FRAMEBUFFER_SRGB during the blit to WGL backbuffers.

Based on #4271

@Zoxc Zoxc requested a review from a team as a code owner October 20, 2023 18:54
@cwfitzgerald
Copy link
Member

Just tested on 1080ti, still works exactly as expected

@cwfitzgerald cwfitzgerald enabled auto-merge (squash) October 20, 2023 20:53
@cwfitzgerald cwfitzgerald merged commit 095b46d into gfx-rs:trunk Oct 20, 2023
23 checks passed
@Zoxc Zoxc deleted the wgl-srgb branch October 20, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants