Changed asc_url to entity_id

[DSigmund]

Respect the User Setting instead of a hardcoded value

What type of PR is this?

• Bug Fix

Description

See #6201

How is this tested?

• Unit tests (pytest, jest)
• E2E Tests (Cypress)
• Manually (Login via ADFS against Local IDP)
• N/A

Related Tickets & Documents

#6201

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

[justinclift]

@getredash/maintainers Is anyone around who understands SAML and has time to review this Python PR? 😄

[codecov]

Codecov Report

Merging #6202 (14714cf) into master (8b8dd4f) will decrease coverage by 1.94%.
The diff coverage is 0.00%.

❗ Current head 14714cf differs from pull request most recent head eb78945. Consider uploading reports for the commit eb78945 to get more accurate results

@@            Coverage Diff             @@
##           master    #6202      +/-   ##
==========================================
- Coverage   61.89%   59.96%   -1.94%     
==========================================
  Files         158      153       -5     
  Lines       12968    12467     -501     
  Branches     1772     1687      -85     
==========================================
- Hits         8027     7476     -551     
- Misses       4665     4783     +118     
+ Partials      276      208      -68     

Files	Coverage Δ
redash/authentication/saml_auth.py	23.80% <0.00%> (ø)

... and 43 files with indirect coverage changes

[guidopetri]

I'm comfortable merging this in if @DSigmund you could confirm that you've deployed this and it works as expected.

I don't think any of the current maintainers have enough SAML knowledge to truly review this PR.

[DSigmund]

It works as expected :-) Many Thanks for merging it!

[DSigmund]

Hi, It fixes the Setting where you have to enter a SAML-URL. You are now able and must enter the correct URL as written in the instructions.

[seiyeah78]

I probably encountered this bug.
After making changes for the upgrade from V8 to V10, I set the Azure AD's entity id to REDASH_SAML_ENTITY_ID, but I ran into an error and couldn't log in successfully.
It worked when I made the Azure AD's entity id exactly the same as the URL for the callback (Assertion Consumer Service URL).
I realized that part of the request was becoming the URL for the callback.
This fix will likely revert it back to normal.

Thank you for addressing this.