Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recently commit breaks existing SAML config setup #6569

Closed
myonlylonely opened this issue Oct 31, 2023 · 1 comment
Closed

Recently commit breaks existing SAML config setup #6569

myonlylonely opened this issue Oct 31, 2023 · 1 comment

Comments

@myonlylonely
Copy link
Contributor

Issue Summary

Commit 55193fb(#6202) breaks our existing SAML config setup, which works on other system as well (like Sentry).
I can no longer login by SAML after this commit.
What exactly does this commit do? Is there any SAML config I should change?

Steps to Reproduce

  1. Update the latest commit.
  2. No longer can login by SAML.

Technical details:

  • Redash Version: Latest Docker preview image
  • Browser/OS: Chrome 118
  • How did you install Redash: Docker
@myonlylonely
Copy link
Contributor Author

OK, I figure it out. I should also change Audience in SAML config after this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@myonlylonely