Bug fix: Use proper default value for weightsdir in file_regrid.py #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the bug described in #278. gcpy/file_regrid.py - Change the default value for weightsdir from False to "." where command line arguments are parsed. This will prevent a TypeError. This bug was likely caused by a cut-n-paste error. Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
topic: Regridding
3 tasks
gcpy/file_regrid.py - Now use "." as the default value for --weightsdir, which will save regridding weights to the current directory. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
lizziel
approved these changes
Dec 8, 2023
yantosca
added a commit
that referenced
this pull request
Dec 8, 2023
This is the official release commit for GCPy 1.4.1. This is a bugfix release that fixes the issue that was described in issue #278. This was resolved with PR #279. Signed-off-by: Bob Yantosca <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR to #278. The proper default value for the
--weightsdirargument togcpy/file_regrid.pyis now used. This had beenFalsebut it should have been".".Expected changes
This will prevent a
TypeErrorwhen the--weightsdirargument is not passed tofile_regrid.py.Related Github Issue(s)