Skip to content

Commit

Permalink
Merge PR #279 (Use proper default for weightsdir in file_regrid.py )
Browse files Browse the repository at this point in the history
This merge brings PR #279 (Bug fix: Use proper default value for
weightsdir in file_regrid.py, by @yantosca) into the GCPy 1.4.1
development stream.

This PR fixes an issue (i.e. incorrect type of default variable resulting
in a TypeError) when calling file_regrid.py without specifying a value for
the --weightsdir command line argument.

Signed-off-by: Bob Yantosca <[email protected]>
  • Loading branch information
yantosca committed Dec 8, 2023
2 parents ba783b9 + 3b92614 commit 9ab1a2d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to GCPy will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased] - TBD
### Fixed
- Now use the proper default value for the `--weightsdir` argument to `gcpy/file_regrid.py`

## [1.4.0] - 2023-11-20
### Added
- Added C2H2 and C2H4 to `emission_species.yml`
Expand Down
2 changes: 1 addition & 1 deletion gcpy/file_regrid.py
Original file line number Diff line number Diff line change
Expand Up @@ -1540,7 +1540,7 @@ def main():
"-w", "--weightsdir",
metavar="WGT",
type=str,
default=False,
default=".",
help="Directory where regridding weights are found (or will be created)"
)
args = parser.parse_args()
Expand Down

0 comments on commit 9ab1a2d

Please sign in to comment.