-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default name assignment to animations without names #413
Conversation
Assings names to animations without names Signed-off-by: Onur Berk Tore <[email protected]>
Signed-off-by: Onur Berk Tore <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 81.06% 81.07%
=======================================
Files 79 79
Lines 9675 9679 +4
=======================================
+ Hits 7843 7847 +4
Misses 1832 1832
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The macOS warning here is due to an ffmpeg update and can be ignored. |
@ahcorde, |
I agree, the GDAL errors are not because of this PR. With approval, we can go ahead and merge here. |
Is the intention to still to target this to |
I have no preference. |
ABI checker likely to fail until there is some release from |
🦟 Bug fix
Related to #393
Summary
Current implementation for the assimp loader does not check the names of the animations loaded through assimp. This PR adds default names for the animations without names. This approach is similar to how ColladaLoader names the animations.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸