-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collada and Assimp test for default animation names #428
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Should this be targeted to #413 instead of |
chapulina
added
bug
Something isn't working
tests
Broken or missing tests / testing infra
labels
Aug 26, 2022
Signed-off-by: Michel Hidalgo <[email protected]> Co-authored-by: Carlos Agüero <[email protected]>
Signed-off-by: Michel Hidalgo <[email protected]>
This is useful for when we perform visualization. Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* Fix arm builds Signed-off-by: Nate Koenig <[email protected]> * Adding in pre-release 5.2.1 Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
* Fix arm test Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]> Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]>
Backports gazebosim#471 to Garden. Signed-off-by: Michel Hidalgo <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Adds paranthesis Signed-off-by: Onur Berk Töre <[email protected]>
onurtore
force-pushed
the
otore/animation_name
branch
from
November 10, 2022 05:44
20df9e2
to
4a61ca7
Compare
I messed this PR, so closing this and going to open a new one. |
Opened #476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #393
Summary
Checks default animation name assigned to collada and assimp loaded meshes. Requires #413 to assimp test to pass.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.