Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collada and Assimp test for default animation names #428

Closed
wants to merge 10 commits into from

Conversation

onurtore
Copy link
Contributor

@onurtore onurtore commented Aug 20, 2022

🦟 Bug fix

Fixes #393

Summary

Checks default animation name assigned to collada and assimp loaded meshes. Requires #413 to assimp test to pass.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@luca-della-vedova
Copy link
Member

luca-della-vedova commented Aug 22, 2022

Should this be targeted to #413 instead of gz-common5 so the feature can be merged / tested together with its test?

@chapulina chapulina added bug Something isn't working tests Broken or missing tests / testing infra labels Aug 26, 2022
hidmic and others added 7 commits October 17, 2022 15:49
Signed-off-by: Michel Hidalgo <[email protected]>
Co-authored-by: Carlos Agüero <[email protected]>
This is useful for when we perform visualization.

Signed-off-by: Arjo Chakravarty <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
* Fix arm builds

Signed-off-by: Nate Koenig <[email protected]>

* Adding in pre-release 5.2.1

Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
* Fix arm test

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Signed-off-by: Nate Koenig <[email protected]>
Co-authored-by: Nate Koenig <[email protected]>
@mjcarroll mjcarroll changed the base branch from gz-common5 to main October 26, 2022 15:16
hidmic and others added 3 commits October 26, 2022 22:24
Signed-off-by: Michael Carroll <[email protected]>
Adds paranthesis

Signed-off-by: Onur Berk Töre <[email protected]>
@onurtore
Copy link
Contributor Author

onurtore commented Nov 10, 2022

I messed this PR, so closing this and going to open a new one.

@onurtore
Copy link
Contributor Author

Opened #476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden tests Broken or missing tests / testing infra
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants