Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve GitHub Actions bug for multi-architecture builds #381

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: Resolve GitHub Actions bug for multi-architecture builds #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
packages: write
steps:
- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Set up Go 1.21
Expand All @@ -30,28 +30,32 @@ jobs:
run: make build-release
- name: Build and release Linux packages
run: make build-linux-packages
- name: Set up QEMU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need QEMU?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want support for more platforms, we should QEMU with the Docker Setup QEMU action.
https://github.com/docker/setup-qemu-action

uses: docker/setup-qemu-action@v3
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Sign in to Docker Hub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Sign in to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Build and push Docker image
uses: docker/build-push-action@v2
uses: docker/build-push-action@v5
with:
context: .
platforms: linux/amd64,linux/arm64
push: true
tags: |
gatewaydio/gatewayd:${{ github.ref_name }}
gatewaydio/gatewayd:latest
ghcr.io/gatewayd-io/gatewayd:${{ github.ref_name }}
ghcr.io/gatewayd-io/gatewayd:latest
platforms: linux/amd64,linux/arm64
- name: Scan Docker image with Syft and generate SBOM
run: |
go install github.com/anchore/syft/cmd/syft@latest
Expand Down