Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve GitHub Actions bug for multi-architecture builds #381

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

hamedsalim1999
Copy link
Member

@hamedsalim1999 hamedsalim1999 commented Dec 18, 2023

Ticket(s)

#378

Description

Resolve GitHub Actions bug for multi-architecture builds by update github action docker steps and add QEMU

Related PRs

N/A

Development Checklist

  • I have added a descriptive title to this PR.
  • I have squashed related commits together.
  • I have rebased my branch on top of the latest main branch.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added docstring(s) and type annotations to my code.
  • I have made corresponding changes to the documentation (docs).
  • I have added tests for my changes.

Legal Checklist

@@ -30,28 +30,32 @@ jobs:
run: make build-release
- name: Build and release Linux packages
run: make build-linux-packages
- name: Set up QEMU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need QEMU?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want support for more platforms, we should QEMU with the Docker Setup QEMU action.
https://github.com/docker/setup-qemu-action

@mostafa mostafa merged commit 1eb6431 into main Dec 18, 2023
@mostafa mostafa deleted the multi-arch branch December 18, 2023 21:26
@mostafa mostafa linked an issue Dec 18, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build multi-platform Docker image
2 participants