Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gandalf Connect: Initial Release #1

Merged
merged 12 commits into from
Jun 15, 2024
Merged

Gandalf Connect: Initial Release #1

merged 12 commits into from
Jun 15, 2024

Conversation

sa-ma
Copy link
Contributor

@sa-ma sa-ma commented Jun 12, 2024 •
edited
Loading

Description

Setup Gandalf Connect

Motivation and Context

How Has This Been Tested?

Screen recording:

https://www.loom.com/share/f16e4af7916446ddb3ce0243062cebb4

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improvement (general improvements to how code looks/works)

Checklist

  • I have created a branch for this patch/feature.
  • My pull request addresses exactly one patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have tested manually.
  • My code follows the code style of this project.

@sa-ma sa-ma marked this pull request as ready for review June 15, 2024 00:06
@sa-ma sa-ma changed the title v0.0.1 Gandalf Connect: Initial Release Jun 15, 2024
@sa-ma sa-ma requested a review from timigod June 15, 2024 00:25
timigod
timigod requested changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@timigod timigod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the dependency/package name to just GandalfConnect instead of GandalfConnectIOS.

@sa-ma sa-ma requested a review from timigod June 15, 2024 09:47
@timigod timigod merged commit 23c1e59 into main Jun 15, 2024
1 check passed
@sa-ma sa-ma deleted the chore/setup branch June 15, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timigod timigod timigod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sa-ma @timigod