Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all files to LF #400

Merged
merged 6 commits into from
Nov 12, 2023
Merged

Convert all files to LF #400

merged 6 commits into from
Nov 12, 2023

Conversation

CosminPerRam
Copy link
Member

@CosminPerRam CosminPerRam commented Oct 30, 2023 •
edited
Loading

Enforces LF.
Closes #392.

@CosminPerRam CosminPerRam marked this pull request as draft October 30, 2023 22:02
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 30, 2023
View reviewed changes
protocols/mumble.js
}

cleanComment (str) {
return str.replace(/<.*>/g, '')

Check failure

Code scanning / CodeQL

Incomplete multi-character sanitization High

This string may still contain
<script
Loading
, which may cause an HTML element injection vulnerability.
@CosminPerRam CosminPerRam marked this pull request as ready for review November 8, 2023 20:11
@CosminPerRam
Copy link
Member Author

Hey @uplusion23, could you double check this? (:

@uplusion23
Copy link

Installed via bun install --global https://github.com/gamedig/node-gamedig.git\#redo_lf,
Ran gamedig, and no longer got ‘node\r’: No such file or directory, seems to be successful! Also checked locally from the redo_lf branch and no IDE or Lint warnings. Thanks!

@uplusion23 uplusion23 mentioned this pull request Nov 8, 2023
Closed
@CosminPerRam CosminPerRam merged commit cee42e7 into master Nov 12, 2023
5 of 6 checks passed
@CosminPerRam CosminPerRam deleted the redo_lf branch January 18, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: CRLF used on 4.1.0
2 participants
@CosminPerRam @uplusion23