Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: CRLF used on 4.1.0 #392

Closed
uplusion23 opened this issue Oct 25, 2023 · 3 comments · Fixed by #400
Closed

bug: CRLF used on 4.1.0 #392

uplusion23 opened this issue Oct 25, 2023 · 3 comments · Fixed by #400
Labels

Comments

@uplusion23
Copy link

uplusion23 commented Oct 25, 2023

Describe the bug
CRLF line endings were pushed with the latest release

Steps To Reproduce
Use 4.1.0 on Unix

Expected behavior
Not Applicable

Screenshots or Data
/usr/bin/env: ‘node\r’: No such file or directory

Additional context
Version 4.0.7 still works

Edit: Fixed as of #400

@uplusion23 uplusion23 added the bug label Oct 25, 2023
@uplusion23
Copy link
Author

This issue is resolved using a dev build, but not on the published version

@CosminPerRam CosminPerRam changed the title bug: CLRF used on 4.1.0 bug: CRLF used on 4.1.0 Oct 27, 2023
@CosminPerRam
Copy link
Member

I've ran this command: find . -not -type d -exec file "{}" ";" | grep CRLF to find CRLF files (sourced from stack overflow) in the gamedig folder in node_modules from a fresh project with 4.0.7 and 4.1.0 and they seem to yield the same output.

Running the project/the bin shows no problems, could you give more information about your setup or what have you done to encounter this?

I do will change the endings to LF as they are more universally supported.

@uplusion23
Copy link
Author

uplusion23 commented Oct 27, 2023

On my Unix machine pulling v4.1.0 seemed to cause the mentioned error when running both via CLI and as a package, yet pulling the latest and running (via npm install https://github.com/gamedig/node-gamedig) was functional. After your reply I ran the same command on my local install [even using the latest git version] and somehow got the following results.

Edit (1 NOV, 2023): This issue also persists on 4.0.7, installed on another *nix system to test, and same result

./node_modules/gamedig/protocols/mafia2mp.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/battlefield.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/core.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/geneshift.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/tribes1master.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/openttd.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/gamespy3.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/fivem.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/tribes1.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/armagetron.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/ut3.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/kspdmp.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/goldsrc.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/gamespy1.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/minecraftbedrock.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/ffow.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/starmade.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/ventrilo.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/nadeo.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/doom3.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/warsow.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/minecraftvanilla.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/jc2mp.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/eco.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/samp.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/savage2.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/minecraft.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/teamspeak3.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/ase.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/hexen2.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/gamespy2.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/discord.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/valve.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/mumbleping.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/mumble.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/teamspeak2.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/assettocorsa.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/starsiege.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/quake1.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/buildandshoot.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/unreal2.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/quake2.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/index.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/cs2d.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/vcmp.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/quake3.js: ASCII text, with CRLF, LF line terminators
./node_modules/gamedig/protocols/terraria.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/mafia2online.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/protocols/rfactor.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/.gitattributes: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/QueryRunner.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/Results.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/DnsResolver.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/ProtocolResolver.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/reader.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/Logger.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/HexUtil.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/GameResolver.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/Promises.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/index.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/lib/GlobalUdpSocket.js: ASCII text, with CRLF line terminators
./node_modules/gamedig/CHANGELOG.md: ASCII text, with CRLF line terminators
./node_modules/gamedig/.nvmrc: Unicode text, UTF-16, little-endian text, with CRLF line terminators
./node_modules/gamedig/bin/gamedig.js: a /usr/bin/env node script, ASCII text executable, with CRLF line terminators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants