-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linter exceptions for all linters that are currently failing #6184
Conversation
e2326f1
to
5c67e5d
Compare
The remaining tool linter errors are all due to linters defined in planemo (working in it: galaxyproject/planemo#1472) Tool tests won't finish with 4 chunks (and likely there fill be failing tests anyway). I will fix the python linter problems. |
Do you want me to fix a few other stuff here or should we merge that and fix other stuff later? If we merge this PR, so we cancel the CI or do we deploy? |
I would not deploy. Since we do not change any tools (I should undo the changes to py and xml files and but them in a separate PR)
I would put any other changes to a separate PRs. |
The |
efdb156
to
5c67e5d
Compare
8ab83ba
to
86a7364
Compare
@bernt-matthias please also have a look at bernt-matthias#107 ... not sure where it should go. Please let me know how you want to have those fixes. |
All the remaining failures are URLs that are not valid anymore. |
86a7364
to
9882d51
Compare
7bd0be4
to
9882d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks a lot!
Attention: deployment skipped! https://github.com/galaxyproject/tools-iuc/actions/runs/10719699458 |
And re-enable warn as linter fail level.
It's like a TODO list :)
Should replace #5650
FOR CONTRIBUTOR: